Re: [PATCH] reiserfs: eliminate minimum window size for bitmapsearching
From: Clay Barnes
Date: Tue Aug 22 2006 - 22:44:04 EST
On 17:11 Tue 22 Aug , Andrew Morton wrote:
> I can see that the bigalloc code as-is is pretty sad, but this is a scary
> patch. It has the potential to cause people significant performance
> problems way, way ahead in the future.
> For example, suppose userspace is growing two files concurrently. It could
> be that the bigalloc code would cause one file's allocation cursor to
> repeatedly jump far away from the second. ie: a beneficial side-effect.
> Without bigalloc that side-effect is lost and the two files blocks end up
> all intermingled.
Perhaps I mis-recall, but shouldn't delayed writes (or something along
those lines) cause a case where two files are being incrementally
written rare? It seems that this case would only occur if two processes
were writing two files in small chunks and calling fsync constantly
(*cough* evolution column resizing bug *cough*), PLUS the two would
have to have the same offset (or close) for the file writes.
It seems that the risk of fragmentation is a lesser danger than the full
system near lock-up caused by the old behavour.
> I don't know if that scenario is realistic, but I bet there are similar
> accidental oddities which can occur as a result of this change.
> But what are they?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/