Re: [PATCH] reiserfs: eliminate minimum window size for bitmapsearching

From: Andrew Morton
Date: Tue Aug 22 2006 - 20:09:08 EST



I can see that the bigalloc code as-is is pretty sad, but this is a scary
patch. It has the potential to cause people significant performance
problems way, way ahead in the future.

For example, suppose userspace is growing two files concurrently. It could
be that the bigalloc code would cause one file's allocation cursor to
repeatedly jump far away from the second. ie: a beneficial side-effect.
Without bigalloc that side-effect is lost and the two files blocks end up
all intermingled.

I don't know if that scenario is realistic, but I bet there are similar
accidental oddities which can occur as a result of this change.

But what are they?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/