Re: [RFC][PATCH] ps command race fix take2 [3/4] profile fix

From: KAMEZAWA Hiroyuki
Date: Tue Aug 22 2006 - 07:22:32 EST


On 22 Aug 2006 13:08:49 +0200
Andi Kleen <ak@xxxxxxx> wrote:

> KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> writes:
>
> > ===================================================================
> > --- linux-2.6.18-rc4.orig/include/linux/sched.h
> > +++ linux-2.6.18-rc4/include/linux/sched.h
> > @@ -808,6 +808,10 @@ struct task_struct {
> > struct list_head ptrace_children;
> > struct list_head ptrace_list;
> >
> > +#if defined(CONFIG_OPROFILE) || defined(CONFIG_OPROFILE_MODULE)
> > + struct list_head dead_tasks;
> > +#endif
>
> Sorry I think this needs a cleaner solution without ifdef. Why can't it use
> the token list? Or some other list head that's unused then.
>

I added them because oprofile doesn't need tokened-list. But adding new
member only for this seems a bit expensive as you point out.
I'll find another way, reuse some list_head or use tokened-list.

-Kame

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/