Re: [RFC][PATCH] ps command race fix take2 [3/4] profile fix

From: Andi Kleen
Date: Tue Aug 22 2006 - 07:06:13 EST


KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> writes:

> ===================================================================
> --- linux-2.6.18-rc4.orig/include/linux/sched.h
> +++ linux-2.6.18-rc4/include/linux/sched.h
> @@ -808,6 +808,10 @@ struct task_struct {
> struct list_head ptrace_children;
> struct list_head ptrace_list;
>
> +#if defined(CONFIG_OPROFILE) || defined(CONFIG_OPROFILE_MODULE)
> + struct list_head dead_tasks;
> +#endif

Sorry I think this needs a cleaner solution without ifdef. Why can't it use
the token list? Or some other list head that's unused then.

Otherwise I would think it it better to use a separate list object to
maintain this list in oprofile.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/