Re: [PATCH] acpi: ec_transaction(), second try

From: Andrew Morton
Date: Mon Aug 21 2006 - 18:50:42 EST

On Mon, 21 Aug 2006 00:27:59 +0200
Lennart Poettering <mzxreary@xxxxxxxxxxx> wrote:

> This is the second version of my patch which unifies the logic of
> ec_read() and ec_write() into ec_transaction(). Most things I wrote
> about the first version are still true:
> The changes are:
> - Updated for Kernel 2.6.18pre (Linus' GIT tree as of today)
> - Fix a bad argument validity check in acpi_ec_poll_transaction() as
> pointed out by Yu Luming.
> - I unified the code in acpi_ec_poll_transaction() and
> acpi_ec_intr_transaction() a little more. Both functions are now just
> wrappers around the new acpi_ec_transaction_unlocked() function. The
> latter contains the EC access logic, the two original
> function now just do their special way of locking and call the the
> new function for the actual work.
> This patch is required for my MSI laptop support patch.
> Based on Linus' GIT tree and should also apply to the current ACPI
> tree.

This isn't a suitable description of this work. Please review, especially section
4 and then send (and maintain) a new changelog, thanks.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at