Re: Linker error on via-velocity driver

From: Francois Romieu
Date: Mon Aug 21 2006 - 18:08:37 EST

Henne <henne@xxxxxxxxxxxxxxxx> :
> I found a bug in the via-velocity driver, but I cant find a maintainer
> for that, so I write to the lists.
> This driver depends on CONFIG_INET (tcp/ip) if CONFIG_PM is enabled.
> This is tested on i386 and x86_64.
> I'm not familiar with network stuff but I don't believe a device should
> depend on a protocol.

See the comment on top of velocity_get_ip() related to wol and arp.

How does it behave with the patch below:

diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 3918990..30f21b6 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -2173,6 +2173,7 @@ config VIA_VELOCITY
select CRC32
select CRC_CCITT
select MII
+ select INET if PM
If you have a VIA "Velocity" based network card say Y here.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at