Re: [PATCH] copy_process: cosmetic ->ioprio tweak

[Andrew Morton]

On Sun, 20 Aug 2006 18:53:21 +0400
Oleg Nesterov <oleg@xxxxxxxxxx> wrote:

> copy_process:
> // holds tasklist_lock + ->siglock
>        /*
>         * inherit ioprio
>         */
>        p->ioprio = current->ioprio;
> 
> Why? ->ioprio was already copied in dup_task_struct().

It might just be a thinko.

> I guess this is needed
> to ensure that the child can't escape sys_ioprio_set(IOPRIO_WHO_{PGRP,USER}),
> yes?

How could the child escape that if this assignment was not present?

> In that case we don't need ->siglock held, and the comment should be updated.

Surely.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/