Re: Two "bugletts" on SPARC 64 @ kernel 2.4

[David Miller]

From: "Jurzitza, Dieter" <DJurzitza@xxxxxxxxxxxxxxxx>
Date: Mon, 21 Aug 2006 13:37:51 +0200

> --- linux/include/linux/module.h	2004-12-15 08:34:44.000000000 +0100
> +++ linux/include/linux/module.h	2004-12-15 08:45:32.000000000 +0100
> @@ -31,7 +31,11 @@
>  /* Used by get_kernel_syms, which is obsolete.  */
>  struct kernel_sym
>  {
> -	unsigned long value;
> +#ifdef __ARCH_SPARC64_ATOMIC__
> +	  unsigned int value;
> +#else
> +          unsigned long value;
> +#endif
>  	char name[60];		/* should have been 64-sizeof(long); oh well */
>  };

1) You should post sparc patches at least CC:'d to sparclinux@xxxxxxxxxxxxxxx
   which is where the Sparc developers hang out.

2) I can't see any reason why this part of your patch can be valid.
   This structure is exported to userspace and therefor is part of
   the user-visible API and thus cannot be changed.

If there is some bug or bogus limitation in the module tools which
limits the number of symbols visible due to the sizing of this
structure, that is what needs to be changed not this structure.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/