[patch 20/20] 1394: fix for recently added firewire patch that breaks things on ppc

From: Greg KH
Date: Mon Aug 21 2006 - 14:49:24 EST

-stable review patch. If anyone has any objections, please let us know.

From: Danny Tholen <obiwan@xxxxxxxxxxx>

Recently a patch was added for preliminary suspend/resume handling on
!PPC_PMAC. However, this broke both suspend and firewire on powerpc
because it saves the pci state after the device has already been disabled.

This moves the save state to before the pmac specific code.

Signed-off-by: Danny Tholen <obiwan@xxxxxxxxxxx>
Cc: Stefan Richter <stefanr@xxxxxxxxxxxxxxxxx>
Cc: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
Cc: Ben Collins <bcollins@xxxxxxxxxx>
Cc: Jody McIntyre <scjody@xxxxxxxxxxxxxx>
Acked-by: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>

drivers/ieee1394/ohci1394.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

--- linux-
+++ linux-
@@ -3548,6 +3548,8 @@ static int ohci1394_pci_resume (struct p

static int ohci1394_pci_suspend (struct pci_dev *pdev, pm_message_t state)
+ pci_save_state(pdev);
if (machine_is(powermac)) {
struct device_node *of_node;
@@ -3559,8 +3561,6 @@ static int ohci1394_pci_suspend (struct

- pci_save_state(pdev);
return 0;

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/