Re: [lm-sensors] [RFC][PATCH] hwmon:fix sparse warnings + error handling
From: Grant Coady
Date: Mon Aug 21 2006 - 12:44:05 EST
On Mon, 21 Aug 2006 11:11:27 +0200, Jean Delvare <khali@xxxxxxxxxxxx> wrote:
>> Thanks for doing this... but Andrew please don't apply it. The sensors project
>> people are working on these even now, and we already have a patch for the
>> w83627hf driver...
>> Jean Delvare (hwmon maintainer) should be sending these up the chain soon.
>> Michal: if you're interested in fixing any of the rest of them, please take
>> a look at the patch above to see the mechanism we intend to use. It actually
>> makes the drivers *smaller* than they were.
>The size change really depends on the driver. For older drivers with
>individual file registration (sometimes hidden behind macros) the
>driver size will indeed shrink, but for newer drivers with loop-based
>file registration, this would be a slight increase in size. Not that it
>really matters anyway, what matters is that we handle errors and file
>deletion properly from now on.
>Michal, if you go on working on this (and this is welcome), please
>follow what Mark did, as this is what we agreed was the best approach.
>Here is a quick status summary for drivers/hwmon:
> o adm9240
Somebody else is welcome to do this one, my last patch was dropped.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/