[PATCH 3/3] sys_get_robust_list: don't take tasklist_lock

From: Oleg Nesterov
Date: Mon Aug 21 2006 - 08:40:10 EST


use rcu locks for find_task_by_pid().

Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>

--- 2.6.18-rc4/kernel/futex.c~3_sgrl 2006-08-21 20:41:15.000000000 +0400
+++ 2.6.18-rc4/kernel/futex.c 2006-08-21 20:59:24.000000000 +0400
@@ -1682,7 +1682,7 @@ sys_get_robust_list(int pid, struct robu
struct task_struct *p;

ret = -ESRCH;
- read_lock(&tasklist_lock);
+ rcu_read_lock();
p = find_task_by_pid(pid);
if (!p)
goto err_unlock;
@@ -1691,7 +1691,7 @@ sys_get_robust_list(int pid, struct robu
!capable(CAP_SYS_PTRACE))
goto err_unlock;
head = p->robust_list;
- read_unlock(&tasklist_lock);
+ rcu_read_unlock();
}

if (put_user(sizeof(*head), len_ptr))
@@ -1699,7 +1699,7 @@ sys_get_robust_list(int pid, struct robu
return put_user(head, head_ptr);

err_unlock:
- read_unlock(&tasklist_lock);
+ rcu_read_unlock();

return ret;
}

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/