Re: [mm patch] drm, minor fixes

From: Frederik Deweerdt
Date: Mon Aug 21 2006 - 08:11:21 EST

(Sorry, I forgot to CCs.)
On Mon, Aug 21, 2006 at 12:22:42PM +0100, Dave Airlie wrote:
> >>
> >>are you sure the callers of these don't wrap it inside a DRM_ERR()
> >>macro ?
> >I changed the values when:
> >- I've checked what seemed right, getting back to the system call.
> > drm_ioctl(), through a call to func().
> > That's the case for:
> > - the EFAULT value in i915_emit_box
> > - two EINVAL values in drm_setversion
> >- the return value wasn't used. That was the case for
> > drm_set_busid return values, I felt having returned values negative
> > from the start was more consistent.
> >
> >Is there a particular change that looked suspicious to you?
> [...], however I doubt any of the codepaths are causing a major problem [...]
I agree, I just corrected those because I happen to stumble upon them.
I've tried a kernel with those corrections alone, and it didn't changed
anything on the oopses.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at