Re: [PATCH] cfq_cic_link: fix? usage of wrong cfq_io_context

From: Jens Axboe
Date: Mon Aug 21 2006 - 02:24:48 EST


On Mon, Aug 21 2006, Oleg Nesterov wrote:
> Obviously, cfq_cic_link() shouldn't free a just allocated cfq_io_context ?
>
> Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>
>
> --- 2.6.18-rc4/block/cfq-iosched.c~7_set 2006-08-20 21:23:25.000000000 +0400
> +++ 2.6.18-rc4/block/cfq-iosched.c 2006-08-21 00:53:27.000000000 +0400
> @@ -1561,7 +1561,7 @@ restart:
> /* ->key must be copied to avoid race with cfq_exit_queue() */
> k = __cic->key;
> if (unlikely(!k)) {
> - cfq_drop_dead_cic(ioc, cic);
> + cfq_drop_dead_cic(ioc, __cic);
> goto restart;
> }

Yep, that's a typo. Applied.

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/