Re: [lm-sensors] [RFC][PATCH] hwmon:fix sparse warnings + error handling

From: Mark M. Hoffman
Date: Sun Aug 20 2006 - 22:34:12 EST

Andrew, Michal:

* Michal Piotrowski <michal.k.k.piotrowski@xxxxxxxxx> [2006-08-20 22:44:30 +0200]:
> This patch fixes 56 sparse "ignoring return value of 'device_create_file'" warnings. It also adds error handling.
> w83627hf.c | 96 ++++++++++++++++++++++++++++++++++++++++++++++++++-----------
> 1 file changed, 80 insertions(+), 16 deletions(-)

Thanks for doing this... but Andrew please don't apply it. The sensors project
people are working on these even now, and we already have a patch for the
w83627hf driver...

Jean Delvare (hwmon maintainer) should be sending these up the chain soon.

Michal: if you're interested in fixing any of the rest of them, please take
a look at the patch above to see the mechanism we intend to use. It actually
makes the drivers *smaller* than they were.


Mark M. Hoffman

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at