Re: [Patch] Signedness issue in drivers/net/phy/phy_device.c

[Richard Knutsson]

Eric Sesterhenn / Snakebyte wrote:

> * Richard Knutsson (ricknu-0@xxxxxxxxxxxxxx) wrote:
>  
>
> > Would it not be preferable to use a 's32' instead of an 'int'? After 
> > all, it seem 'val' needs to be 32 bits.
> >    
>
> not sure, but wouldnt this collide with platforms where an int is 64
> Bits?
>  
Because of 'phy_read'? It shouldn't as long the returning value is 
within the range of the s32.

> Eric
>  
Richard
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/