Re: [PATCH] char/moxa.c: fix endianess and multiple-card issues

From: Alan Cox
Date: Sun Aug 20 2006 - 14:05:06 EST

Ar Gwe, 2006-08-18 am 13:39 +0200, ysgrifennodd Dirk Eibach:
> From: Dirk Eibach <eibach@xxxxxxxx>
> While testing Moxa C218T/PCI on PowerPC 405EP I found that loading
> firmware using the linux kernel driver fails because calculation of the
> checksum is not endianess independent in the original code.

> Signed-off-by: Dirk Eibach <eibach@xxxxxxxx>

Acked-by: Alan Cox <alan@xxxxxxxxxx>

Checksum changes are clearly correct. Other changes is an improvement
but not I think enough to handle malicious firmware attacks. That said
such an attacker has CAP_SYS_RAWIO anyway so that part is irrelevant
except for neatness

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at