Re: [Patch] Fix signedness error in drivers/media/video/vivi.c

From: Alan Cox
Date: Sun Aug 20 2006 - 14:01:42 EST


Ar Sad, 2006-08-19 am 18:19 +0200, ysgrifennodd Eric Sesterhenn:
> Since videobuf_reqbufs() returns negative values on errors the current
> code does no real error checking since gcc removes the comparison.
> This patch fixes this issue by making ret a normal, signed integer.
>
> Signed-off-by: Eric Sesterhenn <snakebyte@xxxxxx>
>

Doesn't apply to latest driver tree but the problem is still present.

Alan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/