Re: [Patch] Signedness issue in drivers/net/3c515.c

From: Alan Cox
Date: Sun Aug 20 2006 - 13:59:38 EST

Ar Sad, 2006-08-19 am 19:37 +0200, ysgrifennodd Eric Sesterhenn:
> hi,
> while playing with gcc 4.1 -Wextra warnings, I came across this one:
> drivers/net/3c515.c:1027: warning: comparison of unsigned expression >= 0 is always true
> Since i is unsigned the >= 0 check in the for loop is always true,
> so we might spin there forever unless the if condition triggers.
> Since i is only used in this loop, this patch changes it to
> an integer.
> Signed-off-by: Eric Sesterhenn <snakebyte@xxxxxx>

Acked-by: Alan Cox <alan@xxxxxxxxxx>

[And put JG on the Cc:]
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at