Re: Complaint about return code convention in queue_work() etc.

From: Ingo Molnar
Date: Sun Aug 20 2006 - 07:11:49 EST

On Fri, 2006-08-18 at 17:39 -0400, Alan Stern wrote:
> Why do the damn things return 0 for error and 1 for success???
> Why don't they use negative error codes for failure, like
> everything else in the kernel?!!
> I've tripped over this at least twice, and on each occasion spent a
> considerable length of time trying to track down the problem.

yeah, lets just flip the logic over, but combined with a rename so that
we dont surprise not-yet-in-tree code [and documentation/books].
queue_work() -> add_work() or something like that.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at