Re: [PATCH/RFC] UART driver for PNX8550/8950 revised

[Vitaly Wool]

On 8/19/06, Russell King <rmk+lkml@xxxxxxxxxxxxxxxx> wrote:

> > >This comment's not correct - where is the break condition disabled?
> > >I thought it might be in the next serial_out() but it seems to be
> > >missing from there as well?
> >
> > I don't think you're right here - break condition is also disabled
> > unsetting the corresponding bit in  IEN register for this particular
> > UART.
>
> Hmm, in that case why does break_ctl do this:
>
> +       lcr = serial_in(sport, PNX8XXX_LCR);
> +       if (break_state == -1)
> +               lcr |= PNX8XXX_UART_LCR_TXBREAK;
> +       else
> +               lcr &= ~PNX8XXX_UART_LCR_TXBREAK;
> +       serial_out(sport, PNX8XXX_LCR, lcr);
>
> which appears to imply that the bit for the break state is in the LCR.
> Moreover, there isn't a PNX8XXX_INT_* bit defined for break.  Confused.

Yeah, looking more attentively into docs, I must admit that you're
right here, and I'm wrong.

Vitaly
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/