Re: [PATCH/RFC] UART driver for PNX8550/8950 revised

From: Vitaly Wool
Date: Sat Aug 19 2006 - 07:29:39 EST

On 8/19/06, Russell King <rmk+lkml@xxxxxxxxxxxxxxxx> wrote:

> >This comment's not correct - where is the break condition disabled?
> >I thought it might be in the next serial_out() but it seems to be
> >missing from there as well?
> I don't think you're right here - break condition is also disabled
> unsetting the corresponding bit in IEN register for this particular

Hmm, in that case why does break_ctl do this:

+ lcr = serial_in(sport, PNX8XXX_LCR);
+ if (break_state == -1)
+ else
+ serial_out(sport, PNX8XXX_LCR, lcr);

which appears to imply that the bit for the break state is in the LCR.
Moreover, there isn't a PNX8XXX_INT_* bit defined for break. Confused.

Yeah, looking more attentively into docs, I must admit that you're
right here, and I'm wrong.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at