Re: Complaint about return code convention in queue_work() etc.

From: Jeff Garzik
Date: Fri Aug 18 2006 - 17:40:47 EST


Alan Stern wrote:
I'd like to lodge a bitter complaint about the return codes used by queue_work() and related functions:

Why do the damn things return 0 for error and 1 for success???
Why don't they use negative error codes for failure, like everything else in the kernel?!!

It's a standard programming idiom: return false (0) for failure, true (non-zero) for success. Boolean.

Certainly the kernel often uses the -errno convention, but it's not a rule.

Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/