Re: [PATCH] PCI: fix ICH6 quirks

[Daniel Ritz]

On Friday 18 August 2006 18.57, Jean Delvare wrote:
> Hi Daniel,
> 
> > [PATCH] PCI: fix ICH6 quirks
> > 
> > - add the ICH6(R) LPC to the ICH6 ACPI quirks. currently only the ICH6-M is
> >   handled. [ PCI_DEVICE_ID_INTEL_ICH6_1 is the ICH6-M LPC, ICH6_0 is the ICH6(R) ]
> 
> No objection.
> 
> > - remove the wrong quirk calling asus_hides_smbus_lpc() for ICH6. the register
> >   modified in asus_hides_smbus_lpc() has a different meaning in ICH6.
> 
> My mistake :( Thanks for fixing it. Do you know if executing the old
> quirk on the ICH6 can cause trouble? In other words, should we backport
> this fix to 2.6.17.y?

the register it touches is part of the "root complex base address" register. so
changing it means the ICH6 decodes a different address range that could conflict
with something else...so yes, i think this is a 2.6.17.x candidate.

rgds
-daniel
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/