Re: [2.6.19 PATCH 4/7] ehea: ethtool interface

From: Thomas Klein
Date: Fri Aug 18 2006 - 11:38:58 EST

Hi Alexey,

first of all thanks a lot for the extensive review.

Alexey Dobriyan wrote:
+ u64 hret = H_HARDWARE;

Useless assignment here and everywhere.

Initializing returncodes to errorstate is a cheap way to prevent
accidentally returning (uninitalized) success returncodes which
can lead to catastrophic misbehaviour.

+static void netdev_get_drvinfo(struct net_device *dev,
+ struct ethtool_drvinfo *info)
+ strncpy(info->driver, DRV_NAME, sizeof(info->driver) - 1);
+ strncpy(info->version, DRV_VERSION, sizeof(info->version) - 1);

Use strlcpy() to not forget -1 accidently.

I agree.

Kind regards
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at