Re: cdev documentation (was Drop second arg of unregister_chrdev())

[Dmitry Torokhov]

On 8/18/06, Rolf Eike Beer <eike-kernel@xxxxxxxxx> wrote:
> While I was sneaking around in the code I found this drivers/char/tty_io:3093
>
>        cdev_init(&driver->cdev, &tty_fops);
>        driver->cdev.owner = driver->owner;
>        error = cdev_add(&driver->cdev, dev, driver->num);
>        if (error) {
>                cdev_del(&driver->cdev);
>
> Isn't the call to cdev_del() just wrong here?

Yes, itlooks like it shouldjust be removed.

--
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/