Re: PATCH: Fix crash case

From: Andi Kleen
Date: Fri Aug 18 2006 - 05:49:38 EST


Jan Engelhardt <jengelh@xxxxxxxxxxxxxxx> writes:

> >If we are going to BUG() not panic() here then we should cover the case
> >of the BUG being compiled out
>
> Bug can be compiled out? Ah well I much rather like this patch because of
> the previous busy-looping, heating CPUs unnecessarily. (There was a thread,
> about that, too.)

cpu_relax() is on most CPUs as busy as a ";". This often annoys me
too (in particular in panic) when the CPU fans spin up and machines
become noisy. Maybe we need a portable halt() macro.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/