Re: [PATCH] NFS: Replace null dentries that appear in readdir's list

From: David Howells
Date: Fri Aug 18 2006 - 05:19:29 EST


Ian Kent <raven@xxxxxxxxxx> wrote:

> Don't we need to return something like NULL here also?

Shouldn't do. It should be reasonable to just continue into the rest of the
function - after all, after calling d_drop() we don't have a dentry any
more[*]...

[*] Lack of a dput() not withstanding.

I'm wondering if I actually need to discard the negative dentry I already have
since I then proceed to allocate a new one.

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/