Re: [RFC][PATCH 0/75] pci_module_init to pci_register_driver conversion

From: Michal Piotrowski
Date: Thu Aug 17 2006 - 09:06:52 EST


On 17/08/06, Jeff Garzik <jeff@xxxxxxxxxx> wrote:
Greg KH wrote:
> On Thu, Aug 17, 2006 at 04:26:35AM +0000, Michal Piotrowski wrote:
>> Hi,
>>
>> pci_module_init is obsolete.
>>
>> This patch series converts pci_module_init to pci_register_driver.
>>
>>
>> Can I remove this?
>>
>> include/linux/pci.h:385
>> /*
>> * pci_module_init is obsolete, this stays here till we fix up all usages of it
>> * in the tree.
>> */
>> #define pci_module_init pci_register_driver
>
> As repeated numerous times, it's up to the network developers if they
> will take this or not.
>
> I'll hold off on taking this series, please push it through the driver
> subsystem maintainers.

It's already in subsystem trees, in fact.

Did you mean http://www.kernel.org/git/?p=linux/kernel/git/davem/net-2.6.19.git;a=shortlog
?

The patches are against 2.6.18-rc4-mm1. Unfortunately patches weren't
delivered to netdev (my fault). I'll add To:<actual maintainer> and
resend.


But it is most definitely not 2.6.18-rc material :)

I agree.


Jeff


Regards,
Michal

--
Michal K. K. Piotrowski
LTG - Linux Testers Group
(http://www.stardust.webpages.pl/ltg/wiki/)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/