Re: [PATCH 1/2]: powerpc/cell spidernet bottom half

From: Linas Vepstas
Date: Wed Aug 16 2006 - 18:53:33 EST

On Wed, Aug 16, 2006 at 11:24:46PM +0200, Arnd Bergmann wrote:
> it only
> seems to be hard to make it go fast using any of them.

Last round of measurements seemed linear for packet sizes between
60 and 600 bytes, suggesting that the hardware can handle a
maximum of 120K descriptors/second, independent of packet size.
I don't know why this is.

> That may
> be the fault of strange locking rules

My fault; a few months ago, we were in panic mode trying to get
the thing functioning reliably, and I put locks around anything
and everything. This last patch removes those locks, and protects
only a few pointers (the incrementing of the head and the tail
pointers, and the location ofthe low watermark) that actually
needed protection. They need protection because the code can
get called in various different ways.

> Cleaning up the TX queue only from ->poll() like all the others

I'll try this ...

> sounds like the right approach to simplify the code.

Its not a big a driver. 'wc' says its 2.3 loc, which
is 1/3 or 1/5 the size of tg3.c or the e1000*c files.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at