Re: + tty-trivial-kzalloc-opportunity.patch added to -mm tree

From: Jesper Juhl
Date: Wed Aug 16 2006 - 17:50:56 EST

On 16/08/06, akpm@xxxxxxxx <akpm@xxxxxxxx> wrote:

The patch titled

tty: trivial kzalloc opportunity

has been added to the -mm tree. Its filename is


See to find
out what to do about this

Subject: tty: trivial kzalloc opportunity
From: Alan Cox <alan@xxxxxxxxxxxxxxxxxxx>

Signed-off-by: Alan Cox <alan@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>

drivers/char/tty_io.c | 8 +-------
1 files changed, 1 insertion(+), 7 deletions(-)

diff -puN drivers/char/tty_io.c~tty-trivial-kzalloc-opportunity drivers/char/tty_io.c
--- a/drivers/char/tty_io.c~tty-trivial-kzalloc-opportunity
+++ a/drivers/char/tty_io.c
@@ -160,17 +160,11 @@ static void release_mem(struct tty_struc
* been initialized in any way but has been zeroed
* Locking: none
- * FIXME: use kzalloc

static struct tty_struct *alloc_tty_struct(void)
- struct tty_struct *tty;
- tty = kmalloc(sizeof(struct tty_struct), GFP_KERNEL);
- if (tty)
- memset(tty, 0, sizeof(struct tty_struct));
- return tty;
+ return (struct tty_struct *)kzalloc(sizeof(struct tty_struct), GFP_KERNEL);
Let's get rid of the typecast - eh?
Might as well also make the function inline given that all that's left
of it is a single call to kzalloc() - and why not simply replace all
calls to this function with a call to kzalloc()?

Jesper Juhl <jesper.juhl@xxxxxxxxx>
Don't top-post
Plain text mails only, please
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at