Re: [PATCH for review] [65/145] i386: Clean up code style inmpparse.c ACPI code
From: Andi Kleen
Date: Wed Aug 16 2006 - 12:28:44 EST
On Wed, 16 Aug 2006 12:08:43 -0400
Len Brown <len.brown@xxxxxxxxx> wrote:
> On Thursday 10 August 2006 15:36, Andi Kleen wrote:
> > Remove some unlinuxy ways to write function parameter definitions.
> > Remove some stray "return;"s
> > No functional change.
> > Cc: len.brown@xxxxxxxxx
> > Signed-off-by: Andi Kleen <ak@xxxxxxx>
> > ---
> > arch/i386/kernel/mpparse.c | 52 ++++++++++++++-------------------------------
> > 1 files changed, 17 insertions(+), 35 deletions(-)
> Maybe it is time to just Lindent the file?
> When I Lindented the ACPI sub-system, I stopped short of mpparse.c.
I think except for the ACPI bits which I already fixed in this patch
everything else was linuxy already.
> As you know, I'd like to see the ACPI part of mpparse.c split out into a different file
> that can be shared by i386 and x86_64.
I'm for splitting out in ACPI/non ACPI (with CONFIG for mpparse), but not for
sharing. I want the freedom to change mpparse's internal data structures without
caring for i386.
The first step would be to get rid some of the hacks that convert ACPI into
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/