Re: [PATCH 5/7] pid: Implement pid_nr

From: Oleg Nesterov
Date: Wed Aug 16 2006 - 09:54:49 EST

On 08/15, Eric W. Biederman wrote:
> +static inline pid_t pid_nr(struct pid *pid)
> +{
> + pid_t nr = 0;
> + if (pid)
> + nr = pid->nr;
> + return nr;
> +}

I think this is not safe, you need rcu locks here or the caller should
do some locking.

Let's look at f_getown() (PATCH 7/7). What if original task which was
pointed by -> has gone, another thread does fcntl(F_SETOWN),
and pid_nr() takes a preemtion after 'if (pid)'? In this case 'pid->nr'
may follow a freed memory.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at