Re: x86_64 command line truncated

From: Andy Whitcroft
Date: Mon Aug 07 2006 - 10:38:07 EST


Andi Kleen wrote:
Andy Whitcroft <apw@xxxxxxxxxxxx> writes:

It seems that the command line on x86_64 is being truncated during boot:

in mm right?
Will try and track it down.

Don't bother, it is likely "early-param" (the patch from
hell). I'll investigate.

-Andi

Well I've narroed it down to the following patch from Andrew:

x86_64-mm-early-param.patch

Basically, that leads setup_arch to return saved_command_line as _the_ command_line. We then run parse_args() against it which assumes it may irrevocabaly change command_line. Previous to this patch saved_command_line and command_line were separate and this was not an issue.

It feels like we should be following the model in the newly added parse_early_parms() and taking a local copy of the command_line here.

-apw
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/