Re: [PATCH] usb: The HID Simple Driver Interface 0.3.0

From: Arjan van de Ven
Date: Fri Aug 04 2006 - 19:37:15 EST



>> Signed-off-by: Liyu <liyu@xxxxxxxxxxxx>
>>
>> diff -Naurp linux-2.6.17.7/drivers/usb/input.orig/hid-core.c linux-2.6.17.7/drivers/usb/input/hid-core.c
>> --- linux-2.6.17.7/drivers/usb/input.orig/hid-core.c 2006-07-25 11:36:01.000000000 +0800
>> +++ linux-2.6.17.7/drivers/usb/input/hid-core.c 2006-08-03 15:44:45.000000000 +0800
>> @@ -4,6 +4,7 @@
>> * Copyright (c) 1999 Andreas Gal
>> * Copyright (c) 2000-2005 Vojtech Pavlik <vojtech@xxxxxxx>
>> * Copyright (c) 2005 Michael Haboustak <mike-@xxxxxxxxxxxx> for Concept2, Inc
>> + * Copyright (c) 2006 Liyu <liyu@xxxxxxxxxxxx> HID simple driver interface
>> */
>>
>> /*
>> @@ -26,6 +27,7 @@
>> #include <asm/byteorder.h>
>> #include <linux/input.h>
>> #include <linux/wait.h>
>> +#include <asm/semaphore.h>
>>

Hi,

btw I just noticed this, but please use mutexes not semaphores in new code. Sorry for not
noticing this earlier, I'll need to adjust my filters I suspect.

Greetings,
Arjan van de Ven
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/