Re: Re : Re : sparsemem usage

From: KAMEZAWA Hiroyuki
Date: Thu Aug 03 2006 - 05:18:27 EST


On Thu, 3 Aug 2006 09:07:06 +0000 (GMT)
moreau francis <francis_moreau2000@xxxxxxxx> wrote:

> Alan Cox wrote:
> >
> > Mapping out parts of a section is quite normal - think about the 640K to
> > 1Mb hole in PC memory space.
>
> OK. But I'm still worry. Please consider the following code
>
> for (...; ...; ...) {
> [...]
> if (pfn_valid(i))
> num_physpages++;
> [...]
> }
>
> In that case num_physpages won't store an accurate value. Still it will be
> used by the kernel to make some statistic assumptions on other kernel
> data structure sizes.
>
In my understanding, pfn_valid() just returns "the page has page struct or not".
So, don't use pfn_valid() to count physical pages..


-Kame

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/