Re: deprecate and convert some sleep_on variants.

From: Rolf Eike Beer
Date: Wed Aug 02 2006 - 01:59:08 EST


Am Dienstag, 1. August 2006 20:06 schrieb Dave Jones:
> We've been carrying this for a dogs age in Fedora. It'd be good to get
> this in -mm, so that it stands some chance of getting upstreamed at some
> point.
>
> Signed-off-by: Arjan van de Ven <arjan@xxxxxxxxxxxxx>
> Signed-off-by: Dave Jones <davej@xxxxxxxxxx>
>
> diff -urNp --exclude-from=/home/davej/.exclude
> linux-1060/drivers/block/DAC960.c linux-1070/drivers/block/DAC960.c ---
> linux-1060/drivers/block/DAC960.c
> +++ linux-1070/drivers/block/DAC960.c
> @@ -6132,6 +6132,9 @@ static boolean DAC960_V2_ExecuteUserComm
> unsigned long flags;
> unsigned char Channel, TargetID, LogicalDriveNumber;
> unsigned short LogicalDeviceNumber;
> + wait_queue_t __wait;
> +
> + init_waitqueue_entry(&__wait, current);

Is this only my opinion or is this really a bad choice for the queues name?

Eike

Attachment: pgp00000.pgp
Description: PGP signature