Re: [patch] lockdep: annotate mm/slab.c

From: Arjan van de Ven
Date: Thu Jul 13 2006 - 15:24:28 EST


On Thu, 2006-07-13 at 12:21 -0700, Linus Torvalds wrote:
>
> On Thu, 13 Jul 2006, Arjan van de Ven wrote:
>
> > On Thu, 2006-07-13 at 11:50 -0700, Linus Torvalds wrote:
> > >
> > > Why isn't the "on_slab_key" local to just the init_lock_keys()
> > > function,
> > > and the #ifdef around it all?
> >
> > it's the same net results; the variable is 0 bytes in size for !LOCKDEP
>
> That's not why I reacted. I reacted because the code is ugly, and would be
> much cleaner if it had everything in one place.

fair enough

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/