Re: [PATCH] s390 hypfs fixes for 2.6.18-rc1-mm1

From: Andrew Morton
Date: Thu Jul 13 2006 - 05:21:22 EST


On Wed, 12 Jul 2006 21:17:53 -0700
Badari Pulavarty <pbadari@xxxxxxxxxx> wrote:

> +static ssize_t hypfs_aio_read(struct kiocb *iocb, const struct iovec *iov,
> + unsigned long nr_segs, loff_t offset)
> {
> char *data;
> size_t len;
> struct file *filp = iocb->ki_filp;
> + /* XXX: temporary */
> + char __user *buf = iov[0].iov_base;
> + size_t count = iov[0].iov_len;
> +
> + if (nr_segs != 1) {
> + count = -EINVAL;
> + goto out;
> + }

err, "temporary" things tend to become permanent. What's the real fix?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/