Re: [PATCH] fbdev: Statically link the framebuffer notification functions

From: Jon Smirl
Date: Tue Jul 11 2006 - 09:45:13 EST


On 7/11/06, Antonino A. Daplas <adaplas@xxxxxxxxx> wrote:
Jon Smirl wrote:
> On 7/11/06, Antonino A. Daplas <adaplas@xxxxxxxxx> wrote:
>> The backlight and lcd subsystems can be notified by the framebuffer layer
>> of blanking events. However, these subsystems, as a whole, can function
>> independently from the framebuffer layer. But in order to enable to
>> the lcd and backlight subsystems, the framebuffer has to be compiled
>> also,
>> effectively sucking in a huge amount of unneeded code. Besides, the
>> dependency
>> is introducing a lot of compilation problems.
>
> This code is effectively rebuilding a fb specific version of
> inter_module_get/put., something that was removed earlier.

Huh? I don't see any semblance of inter_module_* or symbol_* in there.
Read the patch again.

You are providing a fixed point to do a rendezvous between modules
without refcount tracking. That's what inter_module did. The symbol is
being passed implicitly via the entry point names.

Just wrap fb_notifier in a module and it will get tracked.


Tony





--
Jon Smirl
jonsmirl@xxxxxxxxx
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/