Re: [linux-pm] [BUG] sleeping function called from invalid contextduring resume

From: Alan Stern
Date: Mon Jul 10 2006 - 11:38:33 EST


On Mon, 10 Jul 2006, Brown, Len wrote:

> Okay, if system_state is off limits, there here is what I've got
> (interesting part is the last 20 lines)
>
> ACPI: acpi_os_allocate() fixes
>
> Replace acpi_in_resume with a more general hack
> to check irqs_disabled() on any kmalloc() from ACPI.
> While setting (system_state != SYSTEM_RUNNING) on resume
> seemed more general, Andrew Morton preferred this approach.
>
> http://bugzilla.kernel.org/show_bug.cgi?id=3469
>
> Make acpi_os_allocate() into an inline function to
> allow /proc/slab_allocators to work.

Another problem with this patch; it doesn't compile.

Along with the other changes to include/acpi/platform/aclinux.h, you need
to define acpi_size. The easiest way is to #include <acpi/actypes.h> and
then remove the unneeded definitions of acpi_cpu_flags and acpi_thread_id.

Alan Stern

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/