Re: [RFC][PATCH 5/9] -Wshadow: variables named 'up' clash with up()

From: Christoph Hellwig
Date: Mon Jul 10 2006 - 10:49:12 EST


> -static inline void uid_hash_insert(struct user_struct *up, struct list_head *hashent)
> +static inline void uid_hash_insert(struct user_struct *_up, struct list_head *hashent)
> {

Please never use such ugly names. A simply 'u' as variable name would do it
instead in most places.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/