Re: [PATCH v2] cirrus-logic-framebuffer-i2c-support.patch

[Krzysztof Halasa]

"Antonino A. Daplas" <adaplas@xxxxxxx> writes:

>> You're right here, I don't know why I assumed DEPENDS does it
>> automatically.
>
> Use select.

It has a known problem - if the "selected" thing changes (requires
another option etc) things are screwed. With "depends on", you don't
have to track such changes.

While near selects (in the same build directory) are IMHO ok, far
ones are not.

I think it would be different if trying to select something which
can't be selected automatically resulted in a warning. I think
I have to look at it then, but for now I'll use something like
"depends on (FB_CIRRUS=m && I2C && I2C_ALGOBIT) ||
(FB_CIRRUS=y && I2C=y && I2C_ALGOBIT=y)".
-- 
Krzysztof Halasa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/