Re: [2.6 patch] make drivers/mtd/cmdlinepart.c:mtdpart_setup() static

From: Sergei Shtylyov
Date: Mon Jul 10 2006 - 06:55:52 EST


Hello.

David Woodhouse wrote:

This patch makes the needlessly global mtdpart_setup() static.

Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>

--- linux-2.6.17-mm2-full/drivers/mtd/cmdlinepart.c.old 2006-06-26 23:18:39.000000000 +0200
+++ linux-2.6.17-mm2-full/drivers/mtd/cmdlinepart.c 2006-06-26 23:18:51.000000000 +0200
@@ -346,7 +346,7 @@
*
* This function needs to be visible for bootloaders.
*/
-int mtdpart_setup(char *s)
+static int mtdpart_setup(char *s)

Patch lacks sufficient explanation. Explain the relevance of the comment
immediately above the function declaration, in the context of your
patch. Explain your decision to change the behaviour, but not change the
comment itself.

My explanation regarding the relevance of the comment is that it seems to be nonsense.

Do I miss something, or why and how should a bootloader access in-kernel functions?

I'm not entirely sure, but allegedly it does -- Juha, can you elaborate?

In addition, this function might be needed to support parsing of the partition info extracted from the OF device tree (if this way of storing it there will be accepted)...

WBR, Sergei
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/