Re: [Sdhci-devel] PATCH: Fix 32bitism in SDHCI

[Russell King]

On Thu, Jun 15, 2006 at 06:59:26PM +0200, Pierre Ossman wrote:
> Alan Cox wrote:
> > The data field is ulong, pointers fit in ulongs. Casting them to int is
> > bad for 64bit systems.
> 
> It's in my (rather large) queue. I'm just waiting for a merge window. :)

I didn't see the original message, but I suspect this is about the
following, which you can see is already queued up for Linus.

# Base git commit: 0e838b72d54ed189033939258a961f2a0cd59647
#	(Merge branch 'upstream-linus' of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev)
#
# Author:    Andrew Morton (Mon Jun 12 22:10:22 BST 2006)
# Committer: Russell King (Mon Jun 12 22:10:22 BST 2006)
#	
#	[MMC] sdhci truncated pointer fix
#	
#	On 64-bit machines, we just lost the uppermost 32 bits.
#	
#	Signed-off-by: Andrew Morton
#	Signed-off-by: Russell King
#
#	 drivers/mmc/sdhci.c |    2 +-
#	 1 files changed, 1 insertions(+), 1 deletions(-)
#
diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c
--- a/drivers/mmc/sdhci.c
+++ b/drivers/mmc/sdhci.c
@@ -1073,7 +1073,7 @@ static int __devinit sdhci_probe_slot(st
 	tasklet_init(&host->finish_tasklet,
 		sdhci_tasklet_finish, (unsigned long)host);
 
-	setup_timer(&host->timer, sdhci_timeout_timer, (int)host);
+	setup_timer(&host->timer, sdhci_timeout_timer, (long)host);
 
 	ret = request_irq(host->irq, sdhci_irq, SA_SHIRQ,
 		host->slot_descr, host);


-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/