Re: serial_core: verify_port() in wrong spot?

[Russell King]

On Fri, Jun 09, 2006 at 01:59:13PM -0400, Stuart MacDonald wrote:
> From: Russell King [rmk@xxxxxxxxxxxxxxxx]
> > I'd rather verify_port didn't get used for that - it's purpose is to
> > validate changes the admin makes to the port.
> 
> I did figure out that's what it's currently used as, but I didn't want
> to introduce a whole new call just to verify that the UART has 9bit
> capability.
> 
> Why aren't user changes validated?

The only things which users can change is low latency, the alternative
(deprecated) "38400-baud" baud rates, and the custom divisor.  None of
these depend on the low level driver, so there's no point asking the
low level driver to validate them.

> 9bit mode is much more than just words of 9 bit length. Parity is
> gone, replaced by the 9th bit; reads and writes have to treat the
> buffers driver-side buffers as 16 bit-wide instead of 8-bit; reads and
> writes to the hardware are correspondingly different; there are new
> interrupts; software flow control is gone; there's special address
> matching and a new ioctl to set that up.

Well, I'll have to read up on this before I can comment any further.
At the moment I don't feel qualified to answer your questions.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/