Re: [RFC/PATCH 2/2] update sunrpc to use in-kernel sockets API

[James Morris]

On Mon, 12 Jun 2006, Sridhar Samudrala wrote:

> > > -	sendpage = sock->ops->sendpage ? : sock_no_sendpage;
> > > +	sendpage = kernel_sendpage ? : sock_no_sendpage;
> > >     
> > 
> > This is not equivalent.
> > 
> >   
> Actually, we could make this a simple assignment as we check for
> sock->ops->sendpage in
> kernel_sendpage().
>    sendpage = kernel_sendpage;

No, the code there is setting different values for sendpage depending on 
whether the page is in high memory or not.


- James
-- 
James Morris
<jmorris@xxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/