Replace kmalloc and memset in get_undo_list with kzalloc

From: Matt Helsley
Date: Mon Jun 12 2006 - 22:44:03 EST


This patch simplifies get_undo_list() by dropping the unnecessary cast,
removing the size variable, and switching to kzalloc() instead of a
kmalloc() followed by a memset().

This cleanup was split then modified from Jes Sorenson's Task Notifiers
patches.

Signed-off-by: Matt Helsley <matthltc@xxxxxxxxxx>
Cc: Jes Sorensen <jes@xxxxxxx>
--

Compiles, boots.

ipc/sem.c | 5 +----
1 files changed, 1 insertion(+), 4 deletions(-)

Index: linux-2.6.17-rc6/ipc/sem.c
===================================================================
--- linux-2.6.17-rc6.orig/ipc/sem.c
+++ linux-2.6.17-rc6/ipc/sem.c
@@ -1002,19 +1002,16 @@ static inline void unlock_semundo(void)
* This can block, so callers must hold no locks.
*/
static inline int get_undo_list(struct sem_undo_list **undo_listp)
{
struct sem_undo_list *undo_list;
- int size;

undo_list = current->sysvsem.undo_list;
if (!undo_list) {
- size = sizeof(struct sem_undo_list);
- undo_list = (struct sem_undo_list *) kmalloc(size, GFP_KERNEL);
+ undo_list = kzalloc(sizeof(*undo_list), GFP_KERNEL);
if (undo_list == NULL)
return -ENOMEM;
- memset(undo_list, 0, size);
spin_lock_init(&undo_list->lock);
atomic_set(&undo_list->refcnt, 1);
current->sysvsem.undo_list = undo_list;
}
*undo_listp = undo_list;


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/