Re: [PATCH 19/21] swap_prefetch: Conversion of nr_unstable to ZVC

[Con Kolivas]

On Tuesday 13 June 2006 09:57, Con Kolivas wrote:
> On Tuesday 13 June 2006 09:48, Christoph Lameter wrote:
> > On Tue, 13 Jun 2006, Con Kolivas wrote:
> > > Nack. You're changing some other code unintentionally.
> >
> > Is this okay?
>
> Not quite.
>
> Remove the test_pagestate variable entirely and leave the check something
> like:
>
> 	if (!(sp_stat.prefetched_pages % SWAP_CLUSTER_MAX) &&
> 		above_background_load())
> 			goto out;
>
> Thanks

Oh and

The comment should read something like:
	/*
	 * above_background_load() is expensive so we only perform
	 * it every SWAP_CLUSTER_MAX prefetched_pages.
	 * We test to see if we're above_background_load as disk activity
	 * even at low priority can cause interrupt induced scheduling
	 * latencies.
	 */

-- 
-ck
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/