Re: [PATCH] x86 built-in command line

From: Willy Tarreau
Date: Mon Jun 12 2006 - 01:12:21 EST


On Sun, Jun 11, 2006 at 08:38:01PM -0500, Matt Mackall wrote:
> On Mon, Jun 12, 2006 at 02:08:18AM +0200, Arjan van de Ven wrote:
> > On Sun, 2006-06-11 at 18:51 -0500, Matt Mackall wrote:
> > > On Mon, Jun 12, 2006 at 01:40:41AM +0200, Arjan van de Ven wrote:
> > > > On Sun, 2006-06-11 at 16:55 -0500, Matt Mackall wrote:
> > > > > This patch allows building in a kernel command line on x86 as is
> > > > > possible on several other arches.
> > > >
> > > > wouldn't it make more sense to allow the initramfs to set such arguments
> > > > instead?
> > >
> > > Huh?
> > >
> > > Are you suggesting we go digging around in a gzipped initramfs image at
> > > early command line parsing time? I can't really see how that would work.
> >
> > but.. the example you give is for the rootfs.. which is used only really
> > late...
>
> That's not an example, that's just pointing out if you don't specify
> root=, it probably won't boot.

I've had other usages of this : when booting kernels from PXE, it is
very convenient to have default command line arguments in different
images, and not have to modify anything in the boot loader. Moreover,
using a *default* command line allows the boot loader to override the
arguments while it would not be easy from the initramfs. Last but not
least, disabling sensible features such as ACPI/APIC needs to be
performed before initramfs.

Cheers,
Willy

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/