Re: [PATCH] kthread conversion: convert ieee1394 from kernel_thread

From: Stefan Richter
Date: Sat Jun 10 2006 - 14:14:15 EST


Christoph Hellwig wrote:
On Sat, Jun 10, 2006 at 12:34:46PM -0400, Ben Collins wrote:
1394 bus rescanning takes a _lot_ longer than a PCI rescan. If we don't
do this in a kthread, then we have to do it as a tasklet, and take a
chance of stalling for a few seconds (not ms), preventing other
tasklet's from running. Suboptimal, IMO.

This is just user-initiated FC rescans. And I doubt they take as long
as parallel scsi rescans which can go into the minutes range easily.
Nothing will be stalled by calling this except the caller, which would
usually be echo called from some shell, something the user can put in
the background using job control.

There is no such userspace caller yet.

Note, the task of nodemgr, or of a hypothetical userspace replacement, is not only to scan the ROMs of nodes and initiate attachment of protocol drivers but also
- to rescan the ROMs of nodes after bus resets (necessary for protocol
drivers to reconnect, which has restrictions WRT latency),
- IEEE 1394 bus management (which has hard latency restrictions too).
We also started using nodemgr to determine the correct speed at which IEEE 1394b nodes can be reached, i.e. for fairly low-level tasks. And there are further plans for nodemgr like optimization of bus arbitration gaps, or parallelized node scanning.

I am not sure that this can really be loaded off to userspace. And if we would do so, deployment would become painful.
--
Stefan Richter
-=====-=-==- -==- -=-=-
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/