Re: [PATCH] kthread conversion: convert ieee1394 from kernel_thread

From: Christoph Hellwig
Date: Sat Jun 10 2006 - 12:38:07 EST


On Sat, Jun 10, 2006 at 12:34:46PM -0400, Ben Collins wrote:
> 1394 bus rescanning takes a _lot_ longer than a PCI rescan. If we don't
> do this in a kthread, then we have to do it as a tasklet, and take a
> chance of stalling for a few seconds (not ms), preventing other
> tasklet's from running. Suboptimal, IMO.

This is just user-initiated FC rescans. And I doubt they take as long
as parallel scsi rescans which can go into the minutes range easily.
Nothing will be stalled by calling this except the caller, which would
usually be echo called from some shell, something the user can put in
the background using job control.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/